London | 25-SDC-July | Mikiyas Gebremichael | Sprint 1 | Debugging - Hashtag link doesnt work properly#118
Conversation
…n only at the start of the text or after a space
Mikiyas-STP
added
📅 Sprint 1
| Jinja2==3.1.5 | ||
| MarkupSafe==3.0.2 | ||
| psycopg2==2.9.10 | ||
| psycopg2-binary==2.9.10 |
There was a problem hiding this comment.
Do we need to change this file to obtain the expected result?
There was a problem hiding this comment.
Hello @wheresdiasd Thank-you for your feedbacks , i have added the "-binary" to use the version that doesn't require compiling. and it helps me to avoid bugs related to compiling. it is more convenient for me
| if (!text) return text; | ||
| return text.replace( | ||
| /\B#[^#]+/g, | ||
| /(^|\s)(#[\w]+)/g, |
There was a problem hiding this comment.
Why consider " \s " ( blank space ) as start of a hash tag when the start is usually the # signal ?
There was a problem hiding this comment.
I have used the \s in the regex to insure the hashtag starts at a word boundaries and is not part of another word. for example if i have " I love #javascript " it will look at the hashtag just after the blank space.
let me know if this PR is ready to close Thanks
wheresdiasd
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
Debugging - Hashtag link doesn't work properly
Questions
No question